[DOCS] Add snippet tests to retriever API docs #113289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview: |
elasticsearchmachine
added
the
needs:triage
leemthompo
added
Team:Docs
elasticsearchmachine
removed
the
needs:triage
|
Pinging @elastic/es-docs (Team:Docs) |
kderusso
reviewed
Sep 23, 2024
| {"index":{}} | ||
| {"region": "Austria", "year": "2020"} | ||
|
|
||
| PUT /my-embeddings |
There was a problem hiding this comment.
Nitpick: It might be nicer to have a single index restaurants with the combined keyword and vector fields. This would make the examples a bit cleaner.
There was a problem hiding this comment.
Totally! I'll update :cat_frantically_typing:
| ---- | ||
| GET /restaurants/_search | ||
| GET /restaurants,my-embeddings/_search |
There was a problem hiding this comment.
This goes back to my nitpick in tests, I'd like to see us continue to query a single index or alias in this example
| @@ -316,7 +367,7 @@ GET movies/_search | |||
| } | |||
| } | |||
| ---- | |||
| // NOTCONSOLE | |||
| // TEST[skip:uses ELSER] | |||
kderusso
approved these changes
Sep 23, 2024
leemthompo
added a commit
to leemthompo/elasticsearch
that referenced
this pull request
Sep 23, 2024
leemthompo
added a commit
to leemthompo/elasticsearch
that referenced
this pull request
Sep 23, 2024
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 23, 2024
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't test the elser + semantic reranking one, so have to omit those.