Upgrade to Lucene 9.12.0 #113333
Open
Upgrade to Lucene 9.12.0 #113333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…torScorerFactoryTests (#109303) This commit adds a couple of missing supported checks to org.elasticsearch.vec.VectorScorerFactoryTests. Without these the test try, and fail, to run on Windows.
Updated LuceneDocument to take advantage of looking up feature values on existing features and selecting the max when parsing multi-value sparse vectors
Just doing the minimal fixes to making this pass tests again and compile. One trivial constructor adjustment and a few adjustments to task count expectations in some tests from having Lucene fork less.
|
@elasticmachine update branch |
|
There are no new commits on the base branch. |
|
@elasticmachine rerun elasticsearch-ci/part-2-arm |
ChrisHegarty
removed
the
auto-backport-and-merge
|
@elasticmachine update branch |
|
Lucene 9.12.0 has been released. This PR is ready of final review. I cannot officially review in GH, but it LGTM. |
|
My only slight concern is the flat vector formats. Now Lucene 9.12 treats them like exposed normal codecs we need to make sure there aren't any weird name conflicts, etc. with our flat formats. I don't think there should be since ours have a different name. Just wanting to be sure. |
javanna
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade to Lucene 9.12
This PR will be squash-merged, so as to simplify the backport to the 8.x branch.