Conditional stemming for 'persian' analyzer #113482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'persian' analyzer for Lucene 10 comes with PersianStemFilter as the last token filter by default. In order to maintain compatibility for old indices, we only use the new analyzer for newly created indices but configure a legacy analyzer with the old behaviour for older index versions.
cbuescher
added
>enhancement
:Search Relevance/Analysis
|
Documentation preview: |
elasticsearchmachine
added
the
Team:Search Relevance
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
cbuescher
commented
Sep 24, 2024
server/src/main/java/org/elasticsearch/index/analysis/Analysis.java
Outdated
Show resolved
Hide resolved
benwtrent
approved these changes
Sep 26, 2024
server/src/main/java/org/elasticsearch/index/analysis/Analysis.java
Outdated
Show resolved
Hide resolved
javanna
reviewed
Sep 27, 2024
server/src/main/java/org/elasticsearch/search/SearchFeatures.java
Outdated
Show resolved
Hide resolved
|
@elasticmachine run elasticsearch-ci/part-1 |
|
CI Failures on 8.16-bwc are issues coming from "main" so I'm inclined to merge this and wait for a fix/awaitsFix with the next upstream merge |
|
I think that even though we provide backward compatibility with existing indices with this change, it should be marked as "breaking" and have a changelog entry. Users that don't want the additional stemming need to move away from the default analyzer and build their own. |
|
@benwtrent I added a changelog entry, let me know if that reads alright to you. |
javanna
reviewed
Oct 1, 2024
server/src/main/java/org/elasticsearch/index/analysis/AnalyzerProvider.java
Outdated
Show resolved
Hide resolved
…st {p0=range/20_synthetic_source/Date range} elastic#113874
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'persian' analyzer for Lucene 10 comes with PersianStemFilter as the last token filter by default. In order to maintain compatibility for old indices, we only use the new analyzer for newly created indices but configure a legacy analyzer with the old behaviour for older index versions.
Closes #113050