Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust the knn tuning guide #113566

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Adjust the knn tuning guide #113566

wants to merge 1 commit into from
+14 −8

Conversation

benwtrent
Copy link
Member

This adjusts the tuning guide in our docs.

  1. It specifically calls out the downside of excluding values from _source
  2. It removes the suggestion to force-merge segments. Instead, refers to the setting to allow the automatic background merging to create larger segments.

@benwtrent benwtrent added >docs General docs changes auto-backport-and-merge Automatically create backport pull requests and merge when ready v8.16.0 :Search Relevance/Search Catch all for Search Relevance v8.15.3 labels Sep 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

Documentation preview:

@elasticsearchmachine elasticsearchmachine added Team:Docs Meta label for docs team v9.0.0 Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch labels Sep 25, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-relevance (Team:Search Relevance)

mayya-sharipova
mayya-sharipova reviewed Sep 27, 2024
View reviewed changes
docs/reference/how-to/knn-search.asciidoc
@@ -45,6 +45,12 @@ results contains the full document `_source`. When the documents contain
high-dimensional `dense_vector` fields, the `_source` can be quite large and
expensive to load. This could significantly slow down the speed of kNN search.

NOTE: <<docs-reindex, reindex>>, <<docs-update, update>>,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this "NOTE" be after a paragraph where we suggest disabling source?

mayya-sharipova
mayya-sharipova approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@mayya-sharipova mayya-sharipova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @benwtrent , these adjustments are very good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mayya-sharipova mayya-sharipova mayya-sharipova approved these changes

@jimczi jimczi Awaiting requested review from jimczi

Assignees
No one assigned
Labels
auto-backport-and-merge Automatically create backport pull requests and merge when ready >docs General docs changes :Search Relevance/Search Catch all for Search Relevance Team:Docs Meta label for docs team Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch v8.15.3 v8.16.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benwtrent @elasticsearchmachine @mayya-sharipova