-
Notifications
You must be signed in to change notification settings - Fork 24.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates 'Getting ready for production' page #113679
base: main
Are you sure you want to change the base?
Updates 'Getting ready for production' page #113679
Conversation
Documentation preview: |
Pinging @elastic/es-docs (Team:Docs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
feels bad to ✅ this myself because I wrote most of it - will let @leemthompo do a review as well.
Provided some typo/grammar feedback and some thoughts on the scope of the page and deletions that we should consider before merging.
This content is pretty sensitive - might want to loop in @/DaveCTurner for a review - Liam, WYT?
testing with your own data and queries]. | ||
[TIP] | ||
==== | ||
You can also take <<snapshot-restore,snapshots>> of your cluster that can be restored in case of failure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@leemthompo do you think this mention is enough since we introduced it in the overview as well? Should there be another section for snapshot/restore? leaning toward yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shainaraskas Not sure really if we need more than this here, the page is nice and digestible right now
tagging because this reply is now an orphan because I did it as part of a review 😄
💯 Once we're happy we can open this up next week |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once Shaina's comments have been addressed I'm happy to open this up to SME review. I think this work already achieves the goal of expanding and improving the existing page, with zero loss of important information. :)
testing with your own data and queries]. | ||
[TIP] | ||
==== | ||
You can also take <<snapshot-restore,snapshots>> of your cluster that can be restored in case of failure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shainaraskas Not sure really if we need more than this here, the page is nice and digestible right now
tagging because this reply is now an orphan because I did it as part of a review 😄
Co-authored-by: shainaraskas <[email protected]>
Co-authored-by: shainaraskas <[email protected]>
Co-authored-by: shainaraskas <[email protected]>
Co-authored-by: shainaraskas <[email protected]>
Co-authored-by: Liam Thompson <[email protected]>
Co-authored-by: Liam Thompson <[email protected]>
Co-authored-by: shainaraskas <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one formatting change required (h/t @DaveCTurner)
@kosabogi one follow-up task for this might be to grep for all instances of <<scalability, some Link text>>
across the Elasticsearch guide and make sure the link texts make sense now that we've changed the page title.
==== Use multiple nodes and shards for better performance and resilience | ||
++++ | ||
<titleabbrev>Use multiple nodes and shards</titleabbrev> | ||
++++ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
==== Use multiple nodes and shards for better performance and resilience | |
++++ | |
<titleabbrev>Use multiple nodes and shards</titleabbrev> | |
++++ | |
==== Use multiple nodes and shards |
turns out the abbreviation is messing up the left-hand nav, so we can just shorten the heading itself
Work In Progress
Overview
This update adds the Getting ready for production section to the Elasticsearch basics chapter.
FYI: This aims to expand and improve upon existing page
Related Issue
112999
Preview
Getting ready for production