Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore node feature #113805

Merged

Conversation

kkrik-es
Copy link
Contributor

This got rolled back as part of #113692, but the change had already rolled out to QA.

@kkrik-es kkrik-es added >non-issue auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) Team:StorageEngine :StorageEngine/Mapping The storage related side of mappings labels Sep 30, 2024
@kkrik-es kkrik-es self-assigned this Sep 30, 2024
@kkrik-es kkrik-es marked this pull request as ready for review September 30, 2024 14:01
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-storage-engine (Team:StorageEngine)

Copy link
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@thecoop thecoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe worth adding a comment this doesn't actually mean anything?

@kkrik-es
Copy link
Contributor Author

Maybe worth adding a comment this doesn't actually mean anything?

Good point, I'll add in a follow-up to get this in asap.

@elasticsearchmachine elasticsearchmachine merged commit 9365efb into elastic:main Sep 30, 2024
16 checks passed
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

The backport operation could not be completed due to the following error:

An unexpected error occurred when attempting to backport this PR.

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 113805

@kkrik-es kkrik-es deleted the fix/missing-node-feature branch September 30, 2024 15:12
kkrik-es added a commit to kkrik-es/elasticsearch that referenced this pull request Sep 30, 2024
This got rolled back as part of elastic#113692, but the change had already
rolled out to QA.

(cherry picked from commit 9365efb)
elasticsearchmachine pushed a commit that referenced this pull request Sep 30, 2024
This got rolled back as part of #113692, but the change had already
rolled out to QA.

(cherry picked from commit 9365efb)
matthewabbott pushed a commit to matthewabbott/elasticsearch that referenced this pull request Oct 4, 2024
This got rolled back as part of elastic#113692, but the change had already
rolled out to QA.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport pending >non-issue :StorageEngine/Mapping The storage related side of mappings Team:StorageEngine v8.16.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants