Don't validate internal stats if they are empty #113846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
|
Hi @iverase, I've created a changelog YAML for you. |
|
@elasticmachine update branch |
This was referenced Oct 4, 2024
iverase
added a commit
to iverase/elasticsearch
that referenced
this pull request
Oct 4, 2024
Fixes a validation step that might prevent creating empty aggregations iif the output format does not allows negative numbers.
iverase
added a commit
to iverase/elasticsearch
that referenced
this pull request
Oct 4, 2024
Fixes a validation step that might prevent creating empty aggregations iif the output format does not allows negative numbers.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 4, 2024
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 4, 2024
matthewabbott
pushed a commit
to matthewabbott/elasticsearch
that referenced
this pull request
Oct 10, 2024
Fixes a validation step that might prevent creating empty aggregations iif the output format does not allows negative numbers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #107678 we introduced a validation step when creating InternalStats to avoid crashing when serializing the object to json. Unfortunately this check might avoid empty aggregations (when the count metric is equal to zero) to work.
What we note is that the serialization of empty aggregations is hard coded to certain values so it does not need to be validated. Therefore this commit adds a check before validating so we only validate aggregations when count != 0.
fixes #113811