[licensing] Remove unnecessary refresh calls #194499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afharo
force-pushed
the
licensing/remove-unnecessary-force-refreshes
branch
from
b61721e
to
efa4864
Compare
afharo
added
backport:prev-minor
|
Pinging @elastic/kibana-core (Team:Core) |
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
|
Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security) |
gsoldevila
reviewed
Oct 1, 2024
gsoldevila
reviewed
Oct 1, 2024
nreese
approved these changes
Oct 1, 2024
maxcold
reviewed
Oct 2, 2024
| @@ -134,6 +134,7 @@ export class LicensingPlugin implements Plugin<LicensingPluginSetup, LicensingPl | |||
| } | |||
| return { | |||
| refresh: this.refresh, | |||
| getLicense: async () => await firstValueFrom(this.license$!), | |||
There was a problem hiding this comment.
I think it is worth updating docs in the Readme, right now docs say refresh: () => Promise<ILicense> allows a plugin to enforce license retrieval. which reads misleading
There was a problem hiding this comment.
great point! I'll update the readme
There was a problem hiding this comment.
Adressed in dab01c7 (#194499)
maxcold
approved these changes
Oct 2, 2024
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
Page load bundle
Unknown metric groupsAPI count
References to deprecated APIs
Unreferenced deprecated APIs
History
To update your PR or re-run it, just comment with: cc @afharo |
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 3, 2024
(cherry picked from commit f3f53e0)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 3, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [[licensing] Remove unnecessary refresh calls (#194499)](#194499) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Alejandro Fernández Haro","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-03T15:42:39Z","message":"[licensing] Remove unnecessary refresh calls (#194499)","sha":"f3f53e054237087aab8590084cb7c8c10972427c","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","Team:Presentation","release_note:skip","v9.0.0","Team:Cloud Security","backport:prev-minor"],"title":"[licensing] Remove unnecessary refresh calls","number":194499,"url":"https://github.com/elastic/kibana/pull/194499","mergeCommit":{"message":"[licensing] Remove unnecessary refresh calls (#194499)","sha":"f3f53e054237087aab8590084cb7c8c10972427c"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194499","number":194499,"mergeCommit":{"message":"[licensing] Remove unnecessary refresh calls (#194499)","sha":"f3f53e054237087aab8590084cb7c8c10972427c"}}]}] BACKPORT--> Co-authored-by: Alejandro Fernández Haro <[email protected]>
tiansivive
pushed a commit
to tiansivive/kibana
that referenced
this pull request
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removing the usage of
licensing.refresh()as it forces a new retrieval of the license when we only need the current one.For maintainers