[ML] AIOps: Use package instead of context for using field stats flyout #194517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walterra
force-pushed
the
ml-aiops-field-stats-refactor
branch
from
ebec56f
to
a978bae
Compare
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Module Count
Async chunks
Page load bundle
Unknown metric groupsAPI count
async chunk count
History
To update your PR or re-run it, just comment with: cc @walterra |
walterra
added
:ml
v9.0.0
Feature:ML/AIOps
|
Pinging @elastic/ml-ui (:ml) |
walterra
added
backport:skip
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 2, 2024
…ut (elastic#194517) ## Summary Part of elastic#187772. Follow up to elastic#193657. The previous PR elastic#193657 moved `FieldStatsFlyout` to a package, the `aiops` plugin didn't make full use of that refactor by still passing in the flyout into the app context. ### Checklist - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit eebfba4)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 2, 2024
…s flyout (#194517) (#194710) # Backport This will backport the following commits from `main` to `8.x`: - [[ML] AIOps: Use package instead of context for using field stats flyout (#194517)](#194517) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Walter Rafelsberger","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-02T13:23:23Z","message":"[ML] AIOps: Use package instead of context for using field stats flyout (#194517)\n\n## Summary\r\n\r\nPart of https://github.com/elastic/kibana/issues/187772.\r\nFollow up to #193657.\r\n\r\nThe previous PR #193657 moved `FieldStatsFlyout` to a package, the\r\n`aiops` plugin didn't make full use of that refactor by still passing in\r\nthe flyout into the app context.\r\n\r\n### Checklist\r\n\r\n- [x] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"eebfba4f9bfe2592ce92d35aed9cf3c0c8540130","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":[":ml","release_note:skip","v9.0.0","Feature:ML/AIOps","v8.16.0","backport:version"],"title":"[ML] AIOps: Use package instead of context for using field stats flyout","number":194517,"url":"https://github.com/elastic/kibana/pull/194517","mergeCommit":{"message":"[ML] AIOps: Use package instead of context for using field stats flyout (#194517)\n\n## Summary\r\n\r\nPart of https://github.com/elastic/kibana/issues/187772.\r\nFollow up to #193657.\r\n\r\nThe previous PR #193657 moved `FieldStatsFlyout` to a package, the\r\n`aiops` plugin didn't make full use of that refactor by still passing in\r\nthe flyout into the app context.\r\n\r\n### Checklist\r\n\r\n- [x] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"eebfba4f9bfe2592ce92d35aed9cf3c0c8540130"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194517","number":194517,"mergeCommit":{"message":"[ML] AIOps: Use package instead of context for using field stats flyout (#194517)\n\n## Summary\r\n\r\nPart of https://github.com/elastic/kibana/issues/187772.\r\nFollow up to #193657.\r\n\r\nThe previous PR #193657 moved `FieldStatsFlyout` to a package, the\r\n`aiops` plugin didn't make full use of that refactor by still passing in\r\nthe flyout into the app context.\r\n\r\n### Checklist\r\n\r\n- [x] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"eebfba4f9bfe2592ce92d35aed9cf3c0c8540130"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Walter Rafelsberger <[email protected]>
walterra
added a commit
to walterra/kibana
that referenced
this pull request
Oct 11, 2024
…ats flyout (elastic#194517)" This reverts commit eebfba4.
Merged
1 task
walterra
added a commit
that referenced
this pull request
Oct 11, 2024
…ts flyout (#194517) (#195860) ## Summary This reverts #194517 ([ML] AIOps: Use package instead of context for using field stats flyout) committed in eebfba4. The PR refactored how `FieldStatsFlyout` is passed in as a dependency to change point detection. Unfortunately the refactor caused the dropdown to select the split field to break when used in the flyout for the options of the change point detection embeddable. This revert is done to restore the original behavior. In a follow up I will revisit the refactor to work properly. ### Checklist - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 11, 2024
…ts flyout (elastic#194517) (elastic#195860) ## Summary This reverts elastic#194517 ([ML] AIOps: Use package instead of context for using field stats flyout) committed in eebfba4. The PR refactored how `FieldStatsFlyout` is passed in as a dependency to change point detection. Unfortunately the refactor caused the dropdown to select the split field to break when used in the flyout for the options of the change point detection embeddable. This revert is done to restore the original behavior. In a follow up I will revisit the refactor to work properly. ### Checklist - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels) (cherry picked from commit 37a420b)
kibanamachine
added a commit
that referenced
this pull request
Oct 11, 2024
…ld stats flyout (#194517) (#195860) (#195930) # Backport This will backport the following commits from `main` to `8.x`: - [Revert [ML] AIOps: Use package instead of context for using field stats flyout (#194517) (#195860)](#195860) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Walter Rafelsberger","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-11T14:15:53Z","message":"Revert [ML] AIOps: Use package instead of context for using field stats flyout (#194517) (#195860)\n\n## Summary\r\n\r\nThis reverts #194517 ([ML] AIOps: Use package instead of context for\r\nusing field stats flyout) committed in\r\neebfba4f9bfe2592ce92d35aed9cf3c0c8540130.\r\n\r\nThe PR refactored how `FieldStatsFlyout` is passed in as a dependency to\r\nchange point detection. Unfortunately the refactor caused the dropdown\r\nto select the split field to break when used in the flyout for the\r\noptions of the change point detection embeddable.\r\n\r\nThis revert is done to restore the original behavior. In a follow up I\r\nwill revisit the refactor to work properly.\r\n\r\n### Checklist\r\n\r\n- [x] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)","sha":"37a420b950aa7ced58360283ec4a4e63d5d410f8","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug",":ml","release_note:skip","v9.0.0","Feature:ML/AIOps","v8.16.0","backport:version"],"title":"Revert [ML] AIOps: Use package instead of context for using field stats flyout (#194517)","number":195860,"url":"https://github.com/elastic/kibana/pull/195860","mergeCommit":{"message":"Revert [ML] AIOps: Use package instead of context for using field stats flyout (#194517) (#195860)\n\n## Summary\r\n\r\nThis reverts #194517 ([ML] AIOps: Use package instead of context for\r\nusing field stats flyout) committed in\r\neebfba4f9bfe2592ce92d35aed9cf3c0c8540130.\r\n\r\nThe PR refactored how `FieldStatsFlyout` is passed in as a dependency to\r\nchange point detection. Unfortunately the refactor caused the dropdown\r\nto select the split field to break when used in the flyout for the\r\noptions of the change point detection embeddable.\r\n\r\nThis revert is done to restore the original behavior. In a follow up I\r\nwill revisit the refactor to work properly.\r\n\r\n### Checklist\r\n\r\n- [x] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)","sha":"37a420b950aa7ced58360283ec4a4e63d5d410f8"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195860","number":195860,"mergeCommit":{"message":"Revert [ML] AIOps: Use package instead of context for using field stats flyout (#194517) (#195860)\n\n## Summary\r\n\r\nThis reverts #194517 ([ML] AIOps: Use package instead of context for\r\nusing field stats flyout) committed in\r\neebfba4f9bfe2592ce92d35aed9cf3c0c8540130.\r\n\r\nThe PR refactored how `FieldStatsFlyout` is passed in as a dependency to\r\nchange point detection. Unfortunately the refactor caused the dropdown\r\nto select the split field to break when used in the flyout for the\r\noptions of the change point detection embeddable.\r\n\r\nThis revert is done to restore the original behavior. In a follow up I\r\nwill revisit the refactor to work properly.\r\n\r\n### Checklist\r\n\r\n- [x] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)","sha":"37a420b950aa7ced58360283ec4a4e63d5d410f8"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Walter Rafelsberger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #187772.
Follow up to #193657.
The previous PR #193657 moved
FieldStatsFlyoutto a package, theaiopsplugin didn't make full use of that refactor by still passing in the flyout into the app context.Checklist