Elastic client now uses url_prefix from host dictionary. #1869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution - Yes, the integration tests require some API keys etc, so tend to be run via the CI. I unblocked the CI for your changes, so lets let them run there and see. |
|
Buildkite test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have several Elastic clusters hosted in a single Kubernetes cluster. For policy reasons, I can only expose port 443. Instead, I use different URL paths to get the right combination of cluster and elastic/kibana. As a result, Rally was failing as
--target-hostswould end up stripping most of the URL.This change checks if a URL prefix has been configured and passes that through in the ES client factory.
I have ran
make check-all, the unit tests all work but there are some integration test failures. However, I also get the same failures on master so I'm unsure what to do with them.I have signed the contributor agreement.