feat: override adapter at OTP app level #640
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for all your hard works, Tesla already has great support on choosing adapter at different levels.
But, it still have one case that tesla doesn't support - override adapter at OTP app level.
This PR adds that feature, which is useful when we want to use different adapter for different OTP apps.
An example - I installed two packages from Hex:
foo
, whose OTP app name is:foo
, the underlying HTTP client is Teslabar
, whose OTP app name is:bar
, the underlying HTTP client is Tesla, too.I want to use
:finch
as the adapter for them all, but due to some reason, I have to set HTTP proxy forbar
. But,:finch
doesn't support proxy, for now. So I have to use:hackney
, which supports proxy.With this PR, I can do something like:
Feel free to comment. I can make any modifications necessary to ensure this PR is mergeable. ;)