Add global minor modes for features (take two)

[progfolio]

• exwm-core.el (exwm--define-global-minor-mode): Macro for arranging EXWM mode hooks, deprecating enabler functions, logging.
• exwm-background.el: Add global mode definition, autoloads (exwm-background-enable): remove
• exwm-randr.el (randr): as above (exwm-randr-enable): as above
• exwm-systemtray.el (systemtray): as above (exwm-systemtray-mode): as above
• exwm-xim.el (xim): as above (exwm-xim-enable): as above
• exwm-xsettings.el (xsettings): as above (exwm-xsettings-enable): as above

[progfolio]

PROS:

• uses macro to avoid implementation repetition.
• defines deprecated "enable" function

CONS:

• Requires autoload cookie dance (perhaps this could be fixed upstream for Emacs 31)
• Hacky way of reproducing autoload cookie docstring in expansion (not entirely necessary, and could be made more robust)

[Stebalien]

IMO, macroing the internals (as suggested by @minad in #45 (comment)) is probably going to be less painful. It may be a bit more code, but that extra code won't require knowledge of autoload cookies to understand.

[minad]

@Stebalien Yes, let's better go with the simple solution. Hopefully in the future Emacs gets a more flexible mechanism for autoload generation.

[progfolio]

As you wish

[progfolio]

@Stebalien @minad I took the liberty of autoloading the enable functions, too. I see no reason not to.

[minad]

I took the liberty of autoloading the enable functions, too. I see no reason not to.

I prefer if we don't do this. The enable functions are obsolete, haven't been autoloaded so far, so we should keep them not autoloaded, such that we don't encourage their use. Otherwise it looks good.

I will try your PR now.

[minad]

Thanks, merged. I've also updated the commentaries and the wiki, see https://github.com/emacs-exwm/exwm/wiki/Home/_compare/54a6528040108a4e9b804bd83c3bee0644eff903...039e3503e25c5c6736e77614216a90f7f1ba5b71.

[minad]

@progfolio Just to be sure if I recall correctly, you've assigned copyright to the FSF, right?

The next step will be to turn exwm-enable into a proper mode :)

[progfolio]

@progfolio Just to be sure if I recall correctly, you've assigned copyright to the FSF, right?

The next step will be to turn exwm-enable into a proper mode :)

I should have papers on file for contributions to Org-mode. I have contributed to Emacs as well, but I don't recall if I had to sign separate papers or the first signing covered everything.

[progfolio]

The next step will be to turn exwm-enable into a proper mode :)

Agreed here, too

[Stebalien]

I should have papers on file for contributions to Org-mode. I have contributed to Emacs as well, but I don't recall if I had to sign separate papers or the first signing covered everything.

Should be the same thing. The org-mode license headers include:

;; This file is part of GNU Emacs.

[progfolio]

Should be the same thing. The org-mode license headers include:

We should be good in that case.
If need be, just let me know and I can sign again.

[medranocalvo]

I wonder whether the minor modes should be named *-minor-mode. I had to do that when naming exwm-minor-mode because exwm-mode exists. Are there conventions?

@minad, @Stebalien: in general we should ask ELPA Maintainers to check copyright assignment for us. See https://github.com/emacs-exwm/exwm/wiki/Maintenance#check-copyright-assignment. Maybe it's not needed in this case, I defer to your judgement.

@progfolio: thank you and welcome to EXWM!

[minad]

I wonder whether the minor modes should be named *-minor-mode. I had to do that when naming exwm-minor-mode because exwm-mode exists. Are there conventions?

We are probably going to call exwm-minor-mode differently, see the discussion in #53. I proposed names like exwm-window-manager-mode or exwm-wm-mode.

in general we should ask ELPA Maintainers to check copyright assignment for us.

Yes, I do that in case of doubt.