Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add font-lock-function-call compatible faces #784

Merged
merged 3 commits into from
Jun 21, 2024

Conversation

zonuexe
Copy link
Member

@zonuexe zonuexe commented Jun 20, 2024

The font-lock-function-call face has been added in Emacs 29.1. It is reasonable for php-function-call to inherit this face, but it has a large visual impact on existing users. This PR introduces faces with -traditional and -standard suffixes.

  • The face with -traditional suffix is ​​compatible with the traditional faces and does not inherit any faces other than -traditional.
  • The face with -standard suffix inherits font-lock-function-call.

To make it easier for users to switch between these faces, the php-function-call, php-method-call and php-static-method-call custom variables have been added. You can set these to switch to a different face individually. These variables point to the traditional face by default.

If you want to change the face, add these lines to your init.el.

(with-eval-after-load 'php
  (setopt php-function-call 'php-function-call-standard)
  (setopt php-method-call 'php-method-call-standard)
  (setopt php-static-method-call 'php-static-method-call-standard))

refs #782, #783, thanks to @bricka

@zonuexe zonuexe force-pushed the feature/php-function-call-face branch from 965586d to ccd28de Compare June 20, 2024 07:56
@zonuexe zonuexe changed the title Add font-lock-function-call compatible faces Add font-lock-function-call compatible faces Jun 20, 2024
@zonuexe
Copy link
Member Author

zonuexe commented Jun 20, 2024

@bricka If you have any comments about these changes, please let us know.

@zonuexe zonuexe merged commit 4792988 into master Jun 21, 2024
12 of 13 checks passed
@zonuexe zonuexe deleted the feature/php-function-call-face branch June 21, 2024 07:42
@bricka
Copy link
Contributor

bricka commented Jun 21, 2024

Sorry for the delay: looks good to me! We might consider updating the README to mention these as well.

@zonuexe
Copy link
Member Author

zonuexe commented Jun 21, 2024

@bricka Thank you for your cooperation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants