Remove Git LFS from repo #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orionw
commented
Jul 7, 2024
| @@ -7,6 +7,16 @@ | |||
| from models import ModelManager | |||
| from ui import build_side_by_side_ui_anon, build_side_by_side_ui_anon_sts, build_side_by_side_ui_anon_clustering, build_side_by_side_ui_named, build_side_by_side_ui_named_sts, build_side_by_side_ui_named_clustering, build_single_model_ui, build_single_model_ui_sts, build_single_model_ui_clustering | |||
|
|
|||
|
|
|||
| # download the videos | |||
| from huggingface_hub import hf_hub_url | |||
There was a problem hiding this comment.
At runtime we download the videos from Huggingface. No need to keep them in this repo as I assume they are static and people won't be iterating on them.
| @@ -31,8 +32,7 @@ def main( | |||
| if key in model_info[model]: | |||
| model_info[model][RENAME_KEYS[key]] = model_info[model].pop(key) | |||
|
|
|||
| with open(elo_rating_pkl, "rb") as fin: | |||
| elo_rating_results = pickle.load(fin) | |||
| elo_rating_results = load_results(elo_rating_folder) | |||
There was a problem hiding this comment.
Results are now saved and loaded as folders, but it does make the commits quite long as each dataframe is a separate file... sorry!
| @@ -4,3 +4,4 @@ gritlm | |||
| mteb | |||
| plotly | |||
| umap-learn | |||
| kaleido | |||
There was a problem hiding this comment.
Apparently is needed to write Plotly plots to file. We could not save to file, but it was saved in the pickle files, so I thought we might as well write it to file for now.
isaac-chung
reviewed
Jul 7, 2024
Comment on lines
3
to
+4
| mkdir -p results | ||
|
|
||
| mkdir -p results/latest |
There was a problem hiding this comment.
Probably don't need mkdir -p results since we have the new line?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid bandwidth issues with Github's 1GB of Git-LFS bandwidth, remove files that use Git LFS:
@Muennighoff @isaac-chung Can I remove the
index_*/passages.*.ptfiles from Github LFS? I assume not yet and when the other indexes are ready we can remove them, so just lmk. Those are the last git lfs files.