Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add Touche2020v3 and JMTEB #1262

Merged
merged 9 commits into from
Oct 3, 2024

Conversation

Samoed
Copy link
Contributor

@Samoed Samoed commented Sep 29, 2024

Checklist

  • Run tests locally to make sure nothing is broken using make test.
  • Run the formatter to format the code using make lint.

Adding datasets checklist

Reason for dataset addition: #749 #1170

  • I have run the following models on the task (adding the results to the pr). These can be run using the mteb -m {model_name} -t {task_name} command.
  • I have checked that the performance is neither trivial (both models gain close to perfect scores) nor random (both models gain close to random scores).
  • If the dataset is too big (e.g. >2048 examples), considering using self.stratified_subsampling() under dataset_transform()
  • I have filled out the metadata object in the dataset file (find documentation on it here).
  • Run tests locally to make sure nothing is broken using make test.
  • Run the formatter to format the code using make lint.

@isaac-chung isaac-chung changed the title Add Touche2020v3 and JMTEB fix: Add Touche2020v3 and JMTEB Sep 29, 2024
Copy link
Contributor

@KennethEnevoldsen KennethEnevoldsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful thanks for doing this!

We should also add JMTEB to the benchmarks.py file

mteb/tasks/Retrieval/eng/Touche2020Retrieval.py Outdated Show resolved Hide resolved
mteb/tasks/Retrieval/eng/Touche2020Retrieval.py Outdated Show resolved Hide resolved
@KennethEnevoldsen KennethEnevoldsen enabled auto-merge (squash) October 3, 2024 11:57
@Samoed
Copy link
Contributor Author

Samoed commented Oct 3, 2024

@KennethEnevoldsen runner hanged up. Found this issue in python action actions/setup-python#806

@KennethEnevoldsen KennethEnevoldsen merged commit 5074918 into embeddings-benchmark:main Oct 3, 2024
9 checks passed
@Samoed Samoed deleted the add_datasets branch October 3, 2024 13:02
bndos pushed a commit to clinia/mteb that referenced this pull request Oct 3, 2024
* add datasets

* fix metrics

* add Touche2020v3

* fix metadata

* Apply suggestions from code review

Co-authored-by: Kenneth Enevoldsen <[email protected]>

* upd name and supress

* add benchmark class

---------

Co-authored-by: Kenneth Enevoldsen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants