-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add Touche2020v3 and JMTEB #1262
Merged
KennethEnevoldsen
merged 9 commits into
embeddings-benchmark:main
from
Samoed:add_datasets
Oct 3, 2024
Merged
fix: Add Touche2020v3 and JMTEB #1262
KennethEnevoldsen
merged 9 commits into
embeddings-benchmark:main
from
Samoed:add_datasets
Oct 3, 2024
+351
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaac-chung
changed the title
Add Touche2020v3 and JMTEB
fix: Add Touche2020v3 and JMTEB
Sep 29, 2024
KennethEnevoldsen
requested changes
Oct 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonderful thanks for doing this!
We should also add JMTEB to the benchmarks.py file
Co-authored-by: Kenneth Enevoldsen <[email protected]>
17 tasks
KennethEnevoldsen
approved these changes
Oct 3, 2024
@KennethEnevoldsen runner hanged up. Found this issue in python action actions/setup-python#806 |
bndos
pushed a commit
to clinia/mteb
that referenced
this pull request
Oct 3, 2024
* add datasets * fix metrics * add Touche2020v3 * fix metadata * Apply suggestions from code review Co-authored-by: Kenneth Enevoldsen <[email protected]> * upd name and supress * add benchmark class --------- Co-authored-by: Kenneth Enevoldsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make test
.make lint
.Adding datasets checklist
Reason for dataset addition: #749 #1170
mteb -m {model_name} -t {task_name}
command.facebook/contriver
intfloat/multilingual-e5-small
JMTEB leaderboard to compare. I ran
MrTidyRetrieval
only for Bengali, as the Japanese version has 7M documents in context to encode. Overall, the results are similar, with the main difference caused by that JMTEB doesn't include titles.self.stratified_subsampling() under dataset_transform()
make test
.make lint
.