-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: sorting benchmark tasks by MTEB, then alphabetical #1271
base: main
Are you sure you want to change the base?
Conversation
Nice; can you make sure tests pass? |
@Muennighoff Yes, just made sure tests pass by running make tests and got: |
Linting seems to fail tho (https://github.com/embeddings-benchmark/mteb/actions/runs/11153462560/job/31001009542?pr=1271) - Maybe run |
@Muennighoff should be fixed now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Just some quick comments; cc @isaac-chung would be great if you took a look!
@Muennighoff changes pushed for code efficiency |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I think it's ready to merge after resolving the merge conflicts with main.
Addresses #1257
Checklist
make test
.make lint
.Example printout