Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: derive results_directory path from results_repo name #1275

Merged

Conversation

dbuades
Copy link
Contributor

@dbuades dbuades commented Oct 3, 2024

The load_results function includes a results_repo parameter, allowing the use of an alternative Git repository for storing the benchmarking results. This parameter is then passed to the download_of_results function. However, the current implementation requires the alternative repository to be named results, as this name is hardcoded.

This PR updates the code to derive the results_directory path from the repository name, removing the hardcoded requirement and giving more flexibility in naming the alternative repository.

Checklist

  • Run tests locally to make sure nothing is broken using make test.
  • Run the formatter to format the code using make lint.

Copy link
Collaborator

@isaac-chung isaac-chung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thank you!

@isaac-chung isaac-chung merged commit b589c29 into embeddings-benchmark:main Oct 3, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants