Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop deprecated AutoSchema._get_reference method #9525

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

browniebroke
Copy link
Contributor

Description

In preparation for the upcoming 3.16 release, drop AutoSchema._get_reference method which is marked as RemovedInDRF316Warning.

The warning class is now unused, so dropping that as well (shouldn't be needed with DRF 3.16).

As well the unused RemovedInDRF316Warning
Copy link
Member

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there anything related to this to e removed?

@browniebroke
Copy link
Contributor Author

is there anything related to this to e removed?

Is that a question for me? If so, I'm not sure I understand what is being asked, but FWIW I searched for references of this method in the DRF codebase/docs and couldn't find any.

@TGoddessana
Copy link
Contributor

image

There doesn't seem to be anywhere in the codebase where the removed method is being referenced.

image

The removed warning class also doesn't appear to be referenced anywhere in the entire codebase.

Copy link
Member

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may be before/after the release of next major version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants