Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

It's bad form to use URL query parameters with a non-GET request #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

It's bad form to use URL query parameters with a non-GET request #7

wants to merge 1 commit into from

Conversation

jacobo
Copy link
Contributor

@jacobo jacobo commented Jun 26, 2015

please use :body

(Validate as such, will any tests break?)

@jacobo
Copy link
Contributor Author

jacobo commented Jun 26, 2015

except that you will never see this code path in tests 😿

@ryansouza
Copy link
Contributor

@jacobo run this with unmocked tests just to confirm and then merge?

core-client-rb/Rakefile

Line 9 in 304f039

sh "env MOCK_CORE=false CORE_URL=http://api-development.localdev.engineyard.com:9292 bundle exec rspec spec/"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacobo @ryansouza