Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add glyph bar type to mem_bar #768

Open
wants to merge 1 commit into
base: current
Choose a base branch
from
Open

Add glyph bar type to mem_bar #768

wants to merge 1 commit into from

Conversation

facetoe
Copy link
Collaborator

@facetoe facetoe commented Oct 26, 2019

No description provided.

@terminalmage terminalmage self-requested a review October 28, 2019 14:33
terminalmage
terminalmage approved these changes Oct 28, 2019
View reviewed changes
Copy link
Collaborator

@terminalmage terminalmage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice. The only nitpick would be the case-sensitivity in bar_type. It could perhaps use some normalization with .lower(). But not really something I'd argue over.

@facetoe
Copy link
Collaborator Author

facetoe commented Oct 28, 2019

Good point, I'll fix er up

@enkore enkore changed the base branch from master to current September 6, 2020 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terminalmage terminalmage terminalmage approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@facetoe @terminalmage