Skip to content

Commit

Permalink
Display a notification when a commit is successful.
Browse files Browse the repository at this point in the history
  • Loading branch information
enlight committed Apr 27, 2014
1 parent e3d2627 commit 601fd4d
Show file tree
Hide file tree
Showing 3 changed files with 37 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -452,6 +452,18 @@ bool FClient::CommitFiles(
return RunCommand(Command, Output, OutErrors);
}

bool FClient::GetWorkingDirectoryParentRevisionID(
const FString& InWorkingDirectory, FString& OutRevisionID, TArray<FString>& OutErrors
) const
{
TArray<FString> Options;
// just grab the local revision number
Options.Add(FString(TEXT("--template \"{rev}\"")));
FString Command(TEXT("parents"));
AppendCommandOptions(Command, Options, InWorkingDirectory);
return RunCommand(Command, OutRevisionID, OutErrors);
}

void FClient::AppendCommandOptions(
FString& InOutCommand, const TArray<FString>& InOptions, const FString& InWorkingDirectory
)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,11 @@ class FClient : public TSharedFromThis<FClient, ESPMode::ThreadSafe>
const FString& InCommitMessage, TArray<FString>& OutErrors
) const;

/** Get the local ID of the working directory's parent revision. */
bool GetWorkingDirectoryParentRevisionID(
const FString& InWorkingDirectory, FString& OutRevisionID, TArray<FString>& OutErrors
) const;

private:
static void AppendCommandOptions(
FString& InOutCommand, const TArray<FString>& InOptions,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -283,6 +283,26 @@ bool FCheckInWorker::Execute(FCommand& InCommand)
Operation->GetDescription().ToString(), InCommand.ErrorMessages
);

if (bResult)
{
FString RevisionID;
bool bRetrievedID = Client->GetWorkingDirectoryParentRevisionID(
InCommand.GetWorkingDirectory(), RevisionID, InCommand.ErrorMessages
);

if (!bRetrievedID)
{
RevisionID = "???";
}

Operation->SetSuccessMessage(
FText::Format(
LOCTEXT("CommitSuccessful", "Committed revision {0}."),
FText::FromString(RevisionID)
)
);
}

bResult &= Client->GetFileStates(
InCommand.GetWorkingDirectory(), InCommand.GetAbsoluteFiles(), FileStates,
InCommand.ErrorMessages
Expand Down

0 comments on commit 601fd4d

Please sign in to comment.