Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/fet 1625 all data should refetched on refresh #874

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Feat/fet 1625 all data should refetched on refresh #874

wants to merge 14 commits into from

Conversation

nhohb
Copy link
Contributor

@nhohb nhohb commented Sep 16, 2024 •
edited by storywithoutend
Loading

  • Update refetchOnMount=always to ensure data always refetch on mount
  • Add unit test for reactQuery
  • Set the default settings for reactQuery back to the defaults of refetchOnMount=true & staleTime = 0. This allows for condition where if there is a nested query that is mounted after a parent query is loaded, it will not trigger another fetch since the parent query will have been loaded with cached data already.
  • Installed @tanstack/react-query-devtools

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Sep 16, 2024 •
edited
Loading

Deploying ens-app-v3 with  Cloudflare Pages  Cloudflare Pages

Latest commit: bc4f567
Status: ✅  Deploy successful!
Preview URL: https://96a39484.ens-app-v3.pages.dev
Branch Preview URL: https://feat-fet-1625-all-data-shoul.ens-app-v3.pages.dev

View logs

@storywithoutend storywithoutend marked this pull request as ready for review October 9, 2024 07:39
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 15, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeonmanRolls LeonmanRolls LeonmanRolls approved these changes

@storywithoutend storywithoutend Awaiting requested review from storywithoutend

@sugh01 sugh01 Awaiting requested review from sugh01 sugh01 is a code owner

At least 0 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nhohb @LeonmanRolls @storywithoutend