Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

913: Functions for PIT histograms #949

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

913: Functions for PIT histograms #949

wants to merge 8 commits into from

Conversation

sbfnk
Copy link
Contributor

@sbfnk sbfnk commented Oct 16, 2024

Description

This PR closes #913.

It adds plot_histogram_sample() and get_pit_histogram() functions and implements the nonrandomised PIT for count data suggested by Czado et al.

It also removes get_pit() and pit_sample() - I don't think calculating PIT values themselves is very interesting or something anyone would ever want to do but if people disagree we could keep them in.

It also removes plot_pit(). Now that densities of the histogram can be obtained directly I would think that a user will be able to make their own plot.

Checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have included the target issue or issues in the PR title as follows: issue-number: PR title
  • I have tested my changes locally.
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required.
  • I have built the package locally and run rebuilt docs using roxygen2.
  • My code follows the established coding standards and I have run lintr::lint_package() to check for style issues introduced by my changes.
  • I have added a news item linked to this PR.
  • I have reviewed CI checks for this PR and addressed them as far as I am able.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Randomised -> non-randomised PIT for count values
1 participant