Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR closes #913.
It adds
plot_histogram_sample()
andget_pit_histogram()
functions and implements the nonrandomised PIT for count data suggested by Czado et al.It also removes
get_pit()
andpit_sample()
- I don't think calculating PIT values themselves is very interesting or something anyone would ever want to do but if people disagree we could keep them in.It also removes
plot_pit()
. Now that densities of the histogram can be obtained directly I would think that a user will be able to make their own plot.Checklist
lintr::lint_package()
to check for style issues introduced by my changes.