Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

win32: Fix crash on zero-sized REG_SZ values #8912

Open
wants to merge 1 commit into
base: maint
Choose a base branch
from
Open

win32: Fix crash on zero-sized REG_SZ values #8912

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions erts/emulator/drivers/win32/registry_drv.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,8 +374,11 @@ fix_value_result(RegPort* rp, LONG result, DWORD type,
switch (type) {
case REG_SZ:
case REG_EXPAND_SZ:
valueSize--; /* No reason to send the '\0' to Erlang. */
break;
/* No reason to send the trailing '\0', if present, to Erlang. */
if (valueSize > 0 && value[valueSize - 1] == '\0') {
valueSize--;
}
break;
case REG_DWORD_LITTLE_ENDIAN:
case REG_DWORD_BIG_ENDIAN:
/*
Expand Down
Loading