Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create mutexes in heap memory #2202

Merged
merged 3 commits into from
Sep 20, 2024

Conversation

bjoernQ
Copy link
Contributor

@bjoernQ bjoernQ commented Sep 20, 2024

Thank you for your contribution!

We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:

Submission Checklist 📝

  • I have updated existing examples or added new ones (if applicable).
  • I have used cargo xtask fmt-packages command to ensure that all changed code is formatted correctly.
  • My changes were added to the CHANGELOG.md in the proper section.
  • I have added necessary changes to user code to the Migration Guide.
  • My changes are in accordance to the esp-rs API guidelines

Extra:

Pull Request Details 📖

Description

This fixes #2201 and is generally a good thing to do

Testing

See #2201

Copy link
Contributor

@bugadani bugadani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are mutexes deleted via the correct function in the driver? 😅

@bjoernQ
Copy link
Contributor Author

bjoernQ commented Sep 20, 2024

Are mutexes deleted via the correct function in the driver? 😅

In general, they seem to do the right thing - just wpa-supplicant tries to delete a mutex via sem_delete which is "okay" now since we just free the memory

Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we also do the same for the timers in timer_compat, just for completeness sake?

esp-wifi/src/compat/common.rs Show resolved Hide resolved
esp-wifi/src/compat/common.rs Outdated Show resolved Hide resolved
@bjoernQ
Copy link
Contributor Author

bjoernQ commented Sep 20, 2024

Shall we also do the same for the timers in timer_compat, just for completeness sake?

I guess I would prefer to do that separately - but I will create an issue for that

Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MabezDev MabezDev added this pull request to the merge queue Sep 20, 2024
Merged via the queue into esp-rs:main with commit 370f541 Sep 20, 2024
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ESP-WIFI] Index out of bounds panic when connecting to enterprise wifi.
3 participants