Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NVS usage example using the native Rust API #276

Merged
merged 3 commits into from
Aug 27, 2023

Conversation

punkto
Copy link
Contributor

@punkto punkto commented Jul 18, 2023

Please note that I have added a new dependence (postcard) just for the example. I don't know if that is OK for you or it is better to use something already added (json?).

@ivmarkov
Copy link
Collaborator

ivmarkov commented Jul 22, 2023

Dependencies which are only relevant for the [examples] section should be added in the [dev-dependencies] section.

Doing too many things - sorry!
Yes, adding postcard is fine. It is anyway what we should be probably favoring due to its efficiency and compactness.

Copy link
Collaborator

@ivmarkov ivmarkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really just two small nits.

info!("{:?} = {:?}", tag_raw_str, from_bytes::<&str>(the_str));
}
}
Err(e) => info!("Couldn't get tag {} because{:?}", tag_raw_str, e),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: missing space

Err(e) => panic!("Could't get namespace {:?}", e),
};

let tag_raw_u8 = "test_raw_u8";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than tags, can we name these things keys?

)
}
}
Err(e) => info!("Couldn't get tag {} because{:?}", tag_raw_str, e),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto - missing space?

@punkto
Copy link
Contributor Author

punkto commented Aug 6, 2023

done!

@ivmarkov ivmarkov merged commit 1e7fcf6 into esp-rs:master Aug 27, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants