fix(#29): Fix reading arbitrary number of bytes. #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_sync::Read trait impl - Fixes an issue where reading fewer bytes than received from socket would make read block on reading from socket, while there are still unprocessed bytes in mbedtls internal buffers. - Fixes embedded_io_async::Read implementation where read() should return `Ok(0)` at EOF.
AnthonyGrondin
force-pushed
the
fix/reading-arbitrary-number-of-bytes-from-buffer
branch
from
d82f9b8
to
4626e31
Compare
|
There is currently an issue with esp-backtrace's latest patch version - merging anyways |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #29
read()if there's no data #18, whereembedded_io_async::Readwas implemented out of spec, as defined in https://rustdoc.etonomy.org/embedded_io_async/trait.Read.html.