Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable openWakeWord when using microWakeWord #220

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

genehand
Copy link
Contributor

Took me a while to figure out why the on-device wake word was no longer working after a restart until I muted & unmuted. My understanding is that the use_wake_word config is for detecting audio with the esp-adf libraries & VAD then sending the audio data through the pipeline to be processed by openWakeWord. Unfortunately this conflicts with microWakeWord processed locally.

Seems to have been surfaced after the otherwise helpful #214. Before, the on_value automation in wake_word_engine_location would run set_use_wake_word(false) at boot when it's configured for On device detection. Now with the init_in_progress check, that doesn't run and is initially left on.

Here's a potential fix that also removes the use_wake_word config, defaulting to false to match the "On device" initial_option.

May relate to #219 as well.

@jlpouffier
Copy link
Contributor

Yes of course, what an idiot.
That's my fault sorry.

Your PR makes a ton of sense. I will test it now and approve it.

Sorry about that

Copy link
Contributor

@jlpouffier jlpouffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx you very much.
It's perfect!

@jesserockz jesserockz merged commit cf3ab54 into esphome:main Jul 5, 2024
12 of 16 checks passed
@genehand genehand deleted the which-wake-word branch July 5, 2024 17:14
@genehand
Copy link
Contributor Author

genehand commented Jul 5, 2024

No worries, thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants