Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(LP-163): Remove ecc_subsites_menu_link_content_update() as it breaks revisions #467

Merged
merged 4 commits into from
Aug 14, 2024

Conversation

anthonylindsay
Copy link
Collaborator

The Problem

  1. When a node
  2. with a menu link
  3. is transitioned from published to draft
  4. ecc_subsites_menu_link_content_update() is called and it saves the default revision after the draft, meaning the draft is never available.

Solution:

Remove function, as it appears to be redundant.

NB minor db version change for Docksal included in separate commit.

Gotcha

We cannot see why the function is there. We are assuming it is now redundant as all it does is save whatever node a menu link points at.

Testing Notes:

  • edit new drafts for subsite overview, subsite pages. Verify Revisioning works as expected.
  • as we are unsure of the original purpose of the function, try editing various types of content, especially ones in any heirarchy and check all is as expected.

@Polynya Polynya changed the title Remove ecc_subsites_menu_link_content_update() as it breaks revisions fix(LP-163): Remove ecc_subsites_menu_link_content_update() as it breaks revisions Aug 14, 2024
@Polynya Polynya merged commit 6e13749 into develop Aug 14, 2024
Copy link

Stopping Review App and clearing up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants