Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ES6 support #7

Open
michaelficarra opened this issue Jun 23, 2014 · 6 comments
Open

add ES6 support #7

michaelficarra opened this issue Jun 23, 2014 · 6 comments

Comments

@michaelficarra
Copy link
Member

Only for nodes types that also exist in JavaScript.

@michaelficarra
Copy link
Member Author

This implies also creating ES5/ES6 versions of isValid and errors that pass the ECMAScript version through errorsP. Then errorsP can decide which isIdentifierNameES* or isReservedWordES* to use and also do things like duplicate object key and parameter tests for ES6 outside of strict mode.

@drom
Copy link

drom commented Aug 21, 2015

For the errorsP(STATE) object. Would {ES6: true} be sufficient for now? Should it be false by default?

@michaelficarra
Copy link
Member Author

Yeah, that sounds good.

@drom
Copy link

drom commented Aug 21, 2015

Shall we add second optional argument fn(node, options) to the isValid and isValidExpression functions? For the {ES6: true} being valid option.

@drom
Copy link

drom commented Aug 21, 2015

Related pull request: #51

@drom
Copy link

drom commented Aug 21, 2015

Looks like esvalid heavily rely on esutils for AST node type checking.
Where estools/esutils#20 probably need to be fixed before any further work can be done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants