added state.ES6 option check; bumped dependencies #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drom
changed the title
Open
| invalidExpr(1, strictFE(exprStmt({type: "Identifier", name: "let"}))); | ||
| invalidExpr(1, strictFE(exprStmt({type: "Identifier", name: "yield"}))); | ||
| // invalidExpr(1, strictFE(exprStmt({type: "Identifier", name: "let"}))); | ||
| // invalidExpr(1, strictFE(exprStmt({type: "Identifier", name: "yield"}))); |
There was a problem hiding this comment.
These two fail with esutils v2.0.2 In order to use latest version of esutils I have to comment it out.
|
This is a good start, but of course there's so much more that needs to be done for full ES6 support. |
|
No doubt. Much more needs to be done 😎 |
|
Looks like we need to update |
|
Yes, I'm sure esutils will need some updates, but not for the purposes of this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bumped
esutilsandesprimaversion for the ES6 stuffadded state.ES6 property check
bumped
eslintversion and fixed rules to passbumped the rest of the packages for the sake of bumping it