release: release (undraft) GitHub release from release script #18886
Conversation
Signed-off-by: Ivan Valdes <[email protected]>
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted filessee 20 files with indirect coverage changes @@ Coverage Diff @@
## main #18886 +/- ##
==========================================
- Coverage 68.77% 68.76% -0.01%
==========================================
Files 420 420
Lines 35532 35532
==========================================
- Hits 24438 24435 -3
- Misses 9661 9670 +9
+ Partials 1433 1427 -6 Continue to review full report in Codecov by Sentry.
|
| log_warning "" | ||
|
|
||
| # Give a 10 minute timeout to the user to confirm the release. | ||
| read -p "Release GitHub release for ${RELEASE_VERSION} [y/N]? " -t 600 -r confirm |
There was a problem hiding this comment.
I think with a bit more testing / confidence we can simply drop the publishing of the release in draft mode and 10 minute review prompt and simply publish the full release.
It was a really great milestone to see the script automatically creating the GitHub release for us today so let's just get a bit more confidence in the next round of releases and then revisit it :)
There was a problem hiding this comment.
I agree. I was hesitant to add this change, but no matter what arguments I'd pass to gh create release, the draft release in the edit UI always has the "set as latest release" checkbox ticked. So, the workaround was to publish the release by editing it, while passing all the possible arguments.
There was a problem hiding this comment.
I'm going to draft this PR then. We can revisit it when we feel confident about automating the release process.
| "main") | ||
| gh_release_args=(--latest=false --prerelease=true) | ||
| ;; | ||
| "release-3.5") |
There was a problem hiding this comment.
We might want to start capturing a list of tasks in an issue and adding it to the https://github.com/etcd-io/etcd/milestone/38 in order to capture the trivial release related tasks we would need to perform in order to safely cut new release-3.6 branch. For example, updating this script to add the release-3.6 logic.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ivanvc, jmhbnz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ivanvc
changed the title
Release (updraft) GitHub release from the release script after creating it, avoiding the last manual step of this process. However, if the user answers no to the prompt, the script won't exit with a failure code, as it is still possible to manually release it.
I tested this in my fork, and it works as expected.
Part of #18604
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.