Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Local Context #9

Merged
merged 2 commits into from
Feb 13, 2024
Merged

feat: Local Context #9

merged 2 commits into from
Feb 13, 2024

Conversation

pcw109550
Copy link
Collaborator

@pcw109550 pcw109550 commented Feb 8, 2024

Description

Adds localContext. Currently there is no proper method to supply local keys, so wrote yet another cheater function(cheatLocalKey) at preimage oracle. This cheater will be removed when preimage oracle correctly supports loading local data.

Tests

Tweaked existing tests to accept empty local contexts. Instead of calling Cheat method, to support local context the test now calls CheatLoadKey method.

Additional context

Current dependencies on/for this PR:

Copy link
Collaborator

@ImTei ImTei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except PreimageOracle.sol duplication. I think both making another PR and modifying this PR are ok. Do what you prefer! (Same for stacked PRs)

@pcw109550 pcw109550 added this pull request to the merge queue Feb 13, 2024
Merged via the queue into master with commit 8af5ae9 Feb 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants