Interop: Update Inputs (rebased) #12204
Draft
+533
−170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axelKingsley
force-pushed
the
interop-inputs-2
branch
from
9401c1e
to
0ff61f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a recreation of
#12094
but I didn't want to potentially mess up proto's original branch with bad rebase choices.
I pulled in develop and used the
-X theirsstrategy, and then usedrebase -ito remove all the redundant commits that were stuck in the PR. I looked over the PR and compared to thegit diff HEAD~~and it looks like it correctly removed just the parts that already got merged. But if I got that wrong, I can move back to the original branch.