Update EIP-7702: Reorder authorization fields for authority recovery #8679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
github-actions
bot
added
c-update
onbjerg
changed the title
|
✅ All reviewers have approved. |
onbjerg
changed the title
|
This ordering was my mistake, they should be ordered the same throughout. I would like to know from other teams if it's okay to update this for devnet-1? Or will we just update this for future devnets? |
|
Speaking for reth we're ok with changing it for devnet-1:) |
Erigon is okay too. |
Nethermind is okay with this too |
lightclient
approved these changes
Jun 24, 2024
eth-bot
approved these changes
Jun 24, 2024
onbjerg
added a commit
to alloy-rs/alloy
that referenced
this pull request
Jul 1, 2024
3 tasks
onbjerg
added a commit
to alloy-rs/alloy
that referenced
this pull request
Jul 1, 2024
This was referenced Jul 23, 2024
ben186
pushed a commit
to ben186/alloy
that referenced
this pull request
Jul 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently items in the authorization list are ordered:
but in order to recover the authority, we need to reorder the fields to
which in some cases necessitates a secondary type to encode the authorization for recovery. Using the same order for the fields simplifies implementation slightly.