Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TS typings #78 #103

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add TS typings #78 #103

wants to merge 3 commits into from

Conversation

Ricy137
Copy link

@Ricy137 Ricy137 commented Jul 8, 2024

issue #78

@Ricy137 Ricy137 marked this pull request as ready for review July 8, 2024 08:12
SamWilsn
SamWilsn reviewed Sep 3, 2024
View reviewed changes
Copy link
Contributor

@SamWilsn SamWilsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the long wait! This is looking good; thank you so much.

eipw-lint-js/type-checks/package.json
},
"keywords": [],
"author": "",
"license": "ISC",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be MPL-2.0 to match the rest of the project.

eipw-lint-js/src/lib.rs

export type Date<S> = S;

export type DefaultLint<S> =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you think of a way we can get a compile or test failure if this list gets out of sync with DefaultLint?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamWilsn SamWilsn SamWilsn left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ricy137 @SamWilsn