Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regular expression for compactability #114

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

IjayAbby
Copy link

@IjayAbby IjayAbby commented Oct 23, 2024

The expected issue was fixed using the explanation below

Error

Reports common mistakes when referencing other proposals, like omitting the hyphen (EIP1234), or replacing it with a space (EIP 1234).

The Fix

For consistency, all proposals should be referenced in the same way.
Interfaces and contract names should be enclosed in backticks to avoid this error: EIP-1234.
These are the backwards compatibility concerns for the EIP-1234.

@IjayAbby IjayAbby changed the title modify enter_link function Fix regular expression for compactability Oct 29, 2024
@IjayAbby IjayAbby marked this pull request as ready for review October 29, 2024 19:10
@IjayAbby
Copy link
Author

Been doing more background talks with @SamWilsn on discord and this is the last point to note and I quote him

**I put up my branch. Please keep in mind that it won't work until #478 is fixed, but it'll give you an idea of how the API will look. Not to repeat myself too much, but you had an excellent idea to use the markdown source to determine what type of link we're dealing with!

The new function of most interest to you will be: ast_source.**

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant