Merge pull request #246 from samalws-tob/echCovFixes3

Fix off-by-one bug in EVM.Debug.srcMapCodePos
ethereum · Apr 18, 2023 · 8af8347 · 8af8347
2 parents 8323757 + d4010ad
commit 8af8347
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -17,6 +17,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Fixed
 
 - The `prank` cheatcode now transfers value from the correct address
+- Fixed an off-by-one error in `EVM.Debug.srcMapCodePos`
 
 ## [0.50.4] - 2023-03-17
 

diff --git a/src/EVM/Debug.hs b/src/EVM/Debug.hs
@@ -47,7 +47,7 @@ srcMapCodePos :: SourceCache -> SrcMap -> Maybe (Text, Int)
 srcMapCodePos cache sm =
   fmap (second f) $ cache.files ^? ix sm.file
   where
-    f v = ByteString.count 0xa (ByteString.take (sm.offset - 1) v) + 1
+    f v = ByteString.count 0xa (ByteString.take sm.offset v) + 1
 
 srcMapCode :: SourceCache -> SrcMap -> Maybe ByteString
 srcMapCode cache sm =