Merge pull request #27 from ethomson/ethomson/ctype

Use unsigned char for ctype functions
ethomson · Oct 18, 2024 · 559f215 · 559f215
2 parents 55b1192 + 8cf6e8f
commit 559f215
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/ntlm.c b/src/ntlm.c
@@ -988,9 +988,9 @@ NTLM_INLINE(bool) generate_lm_hash(
 	keystr2_len = (password_len > 7) ? MIN(14, password_len) - 7 : 0;
 
 	for (i = 0; i < keystr1_len; i++)
-		keystr1[i] = (unsigned char)toupper(password[i]);
+		keystr1[i] = (unsigned char)toupper((unsigned char)password[i]);
 	for (i = 0; i < keystr2_len; i++)
-		keystr2[i] = (unsigned char)toupper(password[i+7]);
+		keystr2[i] = (unsigned char)toupper((unsigned char)password[i+7]);
 
 	/* DES encrypt the LM constant using the password as the key */
 	des_key_from_password(&key1, keystr1, keystr1_len);