Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: click-event in draggable modal not triggered on mobile device #808

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

coderi421
Copy link

@coderi421 coderi421 commented Mar 20, 2023

Hello, Yev Vlasenko @euvl ~
At first, thank you for your good plugin~

In the process of using the dragable model, I found that the click-event of the mobile device would has some problems, so I made the following correction.

  1. add a "undraggableElement" prop params for configuring undraggable elements, which is more convenient to use
  2. modified the "isInput" method and the INPUT_NODE_NAMES constants to better adapt to the the mobile`s click-event

The above fix can solve the problem on mobile~

Limited ability, make it better~

1. add a "undraggableElement" prop params for configuring undraggable elements, which is more convenient to use
2. modified the "isInput" method and the INPUT_NODE_NAMES constants to better adapt to the the mobile`s click-event
@coderi421 coderi421 closed this Mar 21, 2023
@coderi421 coderi421 reopened this Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant