-
-
Notifications
You must be signed in to change notification settings - Fork 680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync file paths, metadata, and documentation with the problem-specifications repository #2869
Sync file paths, metadata, and documentation with the problem-specifications repository #2869
Conversation
As discussed in the previous PR, I am planning to close that PR and have raised this one to focus on updating documentation, file paths, and metadata—essentially, all changes that do not require manual updates like tests. For the test updates, I will raise seven separate PRs, one for each exercise, to ensure clarity and ease of review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jagdish-15! I've just had a quick glance at the changes.
@@ -16,6 +16,9 @@ | |||
"editor": [ | |||
"src/main/java/Node.java", | |||
"src/main/java/Edge.java" | |||
], | |||
"invalidator": [ | |||
"build.gradle" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you mean to commit this change? It isn't clear to me why we would want to add this to the invalidator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was part of the metadata
sync performed by configlet
with the Problem Specifications repository.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, that makes sense! Thanks for letting me know.
Hi @kahgoh, This commit syncs the metadata of the Pythagorean Triplet exercise and the I wanted to check if contributors typically add their names to the list of authors or contributors when updating an exercise's Thanks! |
I think we normally don't add to the contributors for syncing the |
Hello @kahgoh, I believe there’s been a misunderstanding. I wasn’t referring to syncing the instructions.md. What I meant is that I authored the current introduction.md for the Complex Numbers exercise. My PR was recently accepted in the Problem Specifications repository. So, I wasn’t asking about the syncing process—I’m clarifying that I actually wrote the introduction.md in the Problem Specifications repo. I hope this clears up the confusion. |
Hi @jagdish-15, looking at the past precedence (like, for example, in PR #2644, when the leap docs where re-synced after a rewrite) we still normally don't add to the contributors. Adding the contributor (for changes to the Problem Specification) would require the tracks to be aware of the changes to know when to add to the contributor for the exercise across the tracks, which isn't always easy. |
Hi @kahgoh, Thank you for explaining the precedent regarding contributors. I appreciate the insight and completely understand that it might not always be practical to track and add contributors across different tracks for updates originating from the Problem Specifications repository. I realize I might have been a bit eager in this case, and I truly appreciate your patience in clarifying the usual practices. Moving forward, I'll ensure to align with these norms. Thanks again for your guidance, and I’m glad to have had the opportunity to contribute to the track in any way I can! |
Pull Request
This PR aims to synchronize all previously unsynced tests, file paths, metadata, and documentation with the problem-specifications repository.
Proof of Sync
Reviewer Resources:
Track Policies