MyRocks: cleanup Rdb_convert_to_record_key_decoder class #1503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Since this class is a non-instantiable collection of static methods, delete the rest of special methods (default constructor, move constructor, move assignment operator, destructor) in addition to the currently deleted ones. - Convert method arguments from pointers to references and propagate this up and down the call hierarchy. Most notably this converts many "TABLE *" uses to "const TABLE &" throughout MyRocks, deletes a bit of dead code, converts some constructor assignments to initializer list items. - For touched methods, add [[nodiscard]] as applicable and remove redundant const from parameters, do other minor cleanups. - Move struct Rdb_unpack_func_context definition from rdb_datadic.h to rdb_datadic.cc leaving a forward declaration in the header file.
|
@luqun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the rest of special methods (default constructor, move constructor, move
assignment operator, destructor) in addition to the currently deleted ones.
down the call hierarchy. Most notably this converts many "TABLE *" uses to
"const TABLE &" throughout MyRocks, deletes a bit of dead code, converts some
constructor assignments to initializer list items.
const from parameters, do other minor cleanups.
rdb_datadic.cc leaving a forward declaration in the header file.