Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow parallel testing, take #2 #181

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Commits on Apr 21, 2024

  1. Allow parallel testing, take facebook#2

    Summary:
    Basically a re-do of facebook#158.
    This got rolled back because @Babar wrote 3 different PRs and one of them was bad.
    This one wasn't. Technically it wasn't good either, as it only did `test`, not really `untest`, `run` or `keeptesting`.
    
    This re-do fixes this.
    
    Still the same features:
    * Can parametrize the number of threads in the config, or on the command line, default to the number of cores
    * Reports hosts depending whether they failed ssh or something else
    * Doesn't have any extra dependency, as the thread pool is done in a very simple way
    
    Test Plan:
    Ran it on my machine. Tried test and untest, both worked.
    
    Reviewers: nreeves, dcavalca, jaymzh
    
    Subscribers:
    
    Tasks:
    
    Tags:
    Signed-off-by: Olivier Raginel <[email protected]>
    Babar committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    6434325 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bf6c476 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0647233 View commit details
    Browse the repository at this point in the history
  4. Parallelize cookbook upload too

    Summary:
    As upload can take a very long time, we can just have a dedicated thread for it
    Babar committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    76ef58a View commit details
    Browse the repository at this point in the history
  5. Fix all the lints

    Olivier Raginel committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    8258e7b View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2024

  1. Handle the exceptions better, and also handle the threads we join whe…

    …n we run out of threads in our poor man thread pool implementation
    Olivier Raginel committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    acbceed View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2024

  1. Enhance reporting when things go wrong, including when hosts takes a …

    …while to finish
    Olivier Raginel committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    9f5a2fe View commit details
    Browse the repository at this point in the history