-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow parallel testing, take #2 #181
Open
Babar
wants to merge
7
commits into
facebook:main
Choose a base branch
from
Babar:parallel-testing-v2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Apr 21, 2024
-
Allow parallel testing, take facebook#2
Summary: Basically a re-do of facebook#158. This got rolled back because @Babar wrote 3 different PRs and one of them was bad. This one wasn't. Technically it wasn't good either, as it only did `test`, not really `untest`, `run` or `keeptesting`. This re-do fixes this. Still the same features: * Can parametrize the number of threads in the config, or on the command line, default to the number of cores * Reports hosts depending whether they failed ssh or something else * Doesn't have any extra dependency, as the thread pool is done in a very simple way Test Plan: Ran it on my machine. Tried test and untest, both worked. Reviewers: nreeves, dcavalca, jaymzh Subscribers: Tasks: Tags: Signed-off-by: Olivier Raginel <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 6434325 - Browse repository at this point
Copy the full SHA 6434325View commit details -
Configuration menu - View commit details
-
Copy full SHA for bf6c476 - Browse repository at this point
Copy the full SHA bf6c476View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0647233 - Browse repository at this point
Copy the full SHA 0647233View commit details -
Parallelize cookbook upload too
Summary: As upload can take a very long time, we can just have a dedicated thread for it
Configuration menu - View commit details
-
Copy full SHA for 76ef58a - Browse repository at this point
Copy the full SHA 76ef58aView commit details -
Olivier Raginel committed
Apr 21, 2024 Configuration menu - View commit details
-
Copy full SHA for 8258e7b - Browse repository at this point
Copy the full SHA 8258e7bView commit details
Commits on Apr 22, 2024
-
Handle the exceptions better, and also handle the threads we join whe…
…n we run out of threads in our poor man thread pool implementation
Olivier Raginel committedApr 22, 2024 Configuration menu - View commit details
-
Copy full SHA for acbceed - Browse repository at this point
Copy the full SHA acbceedView commit details
Commits on Apr 23, 2024
-
Enhance reporting when things go wrong, including when hosts takes a …
…while to finish
Olivier Raginel committedApr 23, 2024 Configuration menu - View commit details
-
Copy full SHA for 9f5a2fe - Browse repository at this point
Copy the full SHA 9f5a2feView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.