Skip to content
This repository has been archived by the owner on Jan 13, 2022. It is now read-only.

Swap in Facebook Places ID for Foursquare Venue ID in location search #207

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

DylanFM
Copy link

@DylanFM DylanFM commented Mar 25, 2016

It appears Foursquare IDs were deprecated and have recently been removed from Instagram's API docs. It also appears that the Instagram gem wouldn't search with a Facebook Places ID (the request was always going to either have foursquare_v2_id or lat and lng). So, I swapped in one for the other.

This will break any existing use of the location_search method with a Foursquare Venue ID. Now that Instagram's /locations/search documentation no longer lists foursquare_v2_id as an option, I expect that this is an acceptable breaking change.

Test failures in suite have been fixed in open PR #199.

It appears Foursquare IDs were deprecated and have been removed from
Instagram API docs. It also appears that the Instagram gem wouldn't
search with a Facebook Places ID. So, swapped in one for the other.
Aeon added a commit to Aeon/instagram-ruby-gem that referenced this pull request Sep 22, 2016
…facebook-places

Swap in Facebook Places ID for Foursquare Venue ID in location search
@ghost ghost added the CLA Signed label Sep 22, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants