Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert circleci workflows to github actions #1779

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

robandpdx
Copy link

@robandpdx robandpdx commented Apr 15, 2024

This pull request converts the CircleCI workflows to GitHub actions workflows.

Notes

GPU runners are needed with the label 4-core-ubuntu-gpu-t4.

Two repo secrets are needed for docker hub authentication:

DOCKERHUB_USERNAME
DOCKERHUB_TOKEN

Most of the jobs run via a matrix consisting of python_version, pytorch_version, and cu_version. There are many exclude entries to limit combinations to only those that are run the circleci. As is, if one job in the matrix fails, the remaining jobs will be cancelled. This is probably desireable given these jobs run on expensive GPU runners. This behavior can be changed to allow jobs to complete regardless of some job failures. See handling failures for more information.

The binary_linux_conda_cuda in circleci pulls a docker image, then starts that docker image and runs tests inside of it. I didn't really see the point of this, so I chose to just simply run the tests inside the docker image.

Errors

I did my best to make all the jobs work, but lacking knowledge specific to this project makes it nearly impossible for me to get everything working. Someone with better knowledge of this project will need to address these error.

The following jobs fail with errors:

binary_linux_conda (3.8, 1.12.0, 113)
binary_linux_conda (3.8, 1.12.0, 116)
binary_linux_conda (3.8, 1.12.1, 113)
binary_linux_conda (3.8, 1.12.1, 116)
binary_linux_conda (3.8, 1.13.0, 116)
binary_linux_conda (3.8, 1.13.0, 117)
binary_linux_conda (3.8, 1.13.1, 116)
binary_linux_conda (3.8, 1.13.1, 117)
binary_linux_conda (3.8, 2.0.0, 117)
binary_linux_conda (3.8, 2.0.0, 118)
binary_linux_conda (3.8, 2.0.1, 117)
binary_linux_conda (3.8, 2.0.1, 118)
binary_linux_conda (3.9, 1.12.0, 113)
binary_linux_conda (3.9, 1.12.0, 116)
binary_linux_conda (3.9, 1.12.1, 113)
binary_linux_conda (3.9, 1.12.1, 116)
binary_linux_conda (3.9, 1.13.0, 116)
binary_linux_conda (3.9, 1.13.0, 117)
binary_linux_conda (3.9, 1.13.1, 116)
binary_linux_conda (3.9, 1.13.1, 117)
binary_linux_conda (3.9, 2.0.0, 117)
binary_linux_conda (3.9, 2.0.0, 118)
binary_linux_conda (3.9, 2.0.1, 117)
binary_linux_conda (3.9, 2.0.1, 118)
binary_linux_conda (3.10, 1.12.0, 113)
binary_linux_conda (3.10, 1.12.0, 116)
binary_linux_conda (3.10, 1.12.1, 113)
binary_linux_conda (3.10, 1.12.1, 116)
binary_linux_conda (3.10, 1.13.0, 116)
binary_linux_conda (3.10, 1.13.0, 117)
binary_linux_conda (3.10, 1.13.1, 116)
binary_linux_conda (3.10, 1.13.1, 117)
binary_linux_conda (3.10, 2.0.0, 117)
binary_linux_conda (3.10, 2.0.0, 118)
binary_linux_conda (3.10, 2.0.1, 117)
binary_linux_conda (3.10, 2.0.1, 118)

binary_linux_conda_cuda This job exceeds the 6 hour job execution time limit. See usage limits for more details.
Error: The operation was canceled.

Here is the latest workflow run in my fork.


https://fburl.com/workplace/f6mz6tmw

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 15, 2024
@robandpdx robandpdx force-pushed the convert-facebookresearch-pytorch3d-to-actions-20240328-200138 branch from b436006 to 7f1f95c Compare April 15, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants