Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FTP_USER entry now appended to virtual_users.txt instead of overwriting the whole file #55

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gregory112
Copy link

Check the virtual_users.txt file for FTP_USER entry first, to see if the entry already exists. If the user already exists, it won't be appended to the file. Using ">>" instead of ">" stream which will overwrite the file.

@evantill
Copy link

+1 for this PR

@fauria
Copy link
Owner

fauria commented Sep 29, 2020

Thanks for the PR, @gregory112 !

We can try to find a way for appending virtual users, but the proposed grep approach wont work, as it will behave in an unexpected way if it matches a password.

@yale8848
Copy link

fix this issue here: https://github.com/yale8848/docker-vsftpd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants