Add OTEL spans to SQS trigger #25
Conversation
Signed-off-by: Kate Goldenring <[email protected]>
|
@lann for some reason we're getting weird async Span issues and using |
| @@ -125,7 +126,7 @@ impl TriggerExecutor for SqsTrigger { | |||
| impl SqsTrigger { | |||
| fn start_receive_loop(engine: Arc<TriggerAppEngine<Self>>, client: &aws::Client, component: &Component) -> tokio::task::JoinHandle<TerminationReason> { | |||
| let future = Self::receive(engine, client.clone(), component.clone()); | |||
| tokio::task::spawn(future) | |||
| tokio::task::spawn(future.in_current_span()) | |||
There was a problem hiding this comment.
There is no current span at this point is there? From the docs that appears to make it equivalent to .instrument(Span::new_disabled(...)).
There was a problem hiding this comment.
So it sounds like we may need to add a span to this function (#[instrument(name = "spin_trigger_sqs.start_receive_loop")? From our Spin triggers (HTTP and Redis), it seemed like an initial parent span was implied, so I am a little confused here
There was a problem hiding this comment.
This is the outer span for the HTTP trigger: https://github.com/fermyon/spin/blob/3c4d8320bacdf11c274c6feb91e6a7cd0dcfdaff/crates/trigger-http/src/lib.rs#L389
| @@ -193,7 +194,7 @@ impl SqsMessageProcessor { | |||
| queue_timeout_secs | |||
| } | |||
| } | |||
|
|
|||
| #[instrument(name = "spin_trigger_sqs.process_message", skip_all, fields(otel.name = format!("{} receive", queue_name_from_url(&self.component.queue_url)), messaging.message.id = msg.display_id()))] | |||
There was a problem hiding this comment.
I guess I would still expect this span to show up correctly, but I don't really know how a disabled parent span would play into that...
TODO: Determine why span is only appearing periodically. Seems to do with how we are passing the context of the spans on
spawn.