-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrating class symbol support #16
Integrating class symbol support #16
Commits on Jan 24, 2023
-
Bump Microsoft.PowerShell.SDK from 7.3.1 to 7.3.2 (#1986)
Bumps [Microsoft.PowerShell.SDK](https://github.com/PowerShell/PowerShell) from 7.3.1 to 7.3.2. - [Release notes](https://github.com/PowerShell/PowerShell/releases) - [Commits](PowerShell/PowerShell@v7.3.1...v7.3.2) --- updated-dependencies: - dependency-name: Microsoft.PowerShell.SDK dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 3938982 - Browse repository at this point
Copy the full SHA 3938982View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7270bed - Browse repository at this point
Copy the full SHA 7270bedView commit details -
Configuration menu - View commit details
-
Copy full SHA for 69a66bb - Browse repository at this point
Copy the full SHA 69a66bbView commit details -
Configuration menu - View commit details
-
Copy full SHA for e3845e8 - Browse repository at this point
Copy the full SHA e3845e8View commit details -
Configuration menu - View commit details
-
Copy full SHA for b1187b9 - Browse repository at this point
Copy the full SHA b1187b9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7cf22f0 - Browse repository at this point
Copy the full SHA 7cf22f0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 13adfc3 - Browse repository at this point
Copy the full SHA 13adfc3View commit details -
Configuration menu - View commit details
-
Copy full SHA for f2be365 - Browse repository at this point
Copy the full SHA f2be365View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1d1b5cc - Browse repository at this point
Copy the full SHA 1d1b5ccView commit details -
Configuration menu - View commit details
-
Copy full SHA for 50e8a6c - Browse repository at this point
Copy the full SHA 50e8a6cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4c3a4ab - Browse repository at this point
Copy the full SHA 4c3a4abView commit details -
Configuration menu - View commit details
-
Copy full SHA for ad58bcd - Browse repository at this point
Copy the full SHA ad58bcdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 12b1366 - Browse repository at this point
Copy the full SHA 12b1366View commit details -
Configuration menu - View commit details
-
Copy full SHA for 884fecb - Browse repository at this point
Copy the full SHA 884fecbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 109dbb0 - Browse repository at this point
Copy the full SHA 109dbb0View commit details -
Configuration menu - View commit details
-
Copy full SHA for e776984 - Browse repository at this point
Copy the full SHA e776984View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4be7724 - Browse repository at this point
Copy the full SHA 4be7724View commit details -
Configuration menu - View commit details
-
Copy full SHA for bca3de0 - Browse repository at this point
Copy the full SHA bca3de0View commit details -
Configuration menu - View commit details
-
Copy full SHA for da2ad17 - Browse repository at this point
Copy the full SHA da2ad17View commit details -
Configuration menu - View commit details
-
Copy full SHA for 98fbfbd - Browse repository at this point
Copy the full SHA 98fbfbdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3eebb45 - Browse repository at this point
Copy the full SHA 3eebb45View commit details -
Rename overloaded method to
ScanForReferencesOfSymbol
Since `FindReferencesOfSymbol` is already used.
Configuration menu - View commit details
-
Copy full SHA for 6469411 - Browse repository at this point
Copy the full SHA 6469411View commit details -
Migrate
FindReferencesVisitor
toReferenceTable.ReferenceVisitor
This required using a `ScriptFile` for the associated test in `AstOperationsTests`. The coupling of the visitor to the file seems fine since that's the _point_ of this improvement: a cached sets of references for each file. We also have to carefully sort our list of symbol references for things that expect them in order.
Configuration menu - View commit details
-
Copy full SHA for cf79fd0 - Browse repository at this point
Copy the full SHA cf79fd0View commit details -
Deduplicate
GetSymbolKind
,GetDecoratedSymbolName
, and `GetRangeF……romScriptRegion` At least I'm pretty sure these were unnecessary duplicates.
Configuration menu - View commit details
-
Copy full SHA for a335897 - Browse repository at this point
Copy the full SHA a335897View commit details -
Move reference sorting to unit tests
Since the client doesn't actually care which order we return the references in, we should skip unnecessarily sorting. It appears to apply its own sorting to the results regardless of their order, and the specification doesn't say it needs to be sorted. Also adjust two tests to account for the definitions being in the reference lists.
Configuration menu - View commit details
-
Copy full SHA for fe3a37e - Browse repository at this point
Copy the full SHA fe3a37eView commit details -
Configuration menu - View commit details
-
Copy full SHA for b17059d - Browse repository at this point
Copy the full SHA b17059dView commit details -
Track declarations on
SymbolType
so we can useReferenceTable
moreThis lets us (nearly) replace `FindSymbolsInDocument` by using the references (symbols) from the `ScriptFile`.
Configuration menu - View commit details
-
Copy full SHA for 3a3059f - Browse repository at this point
Copy the full SHA 3a3059fView commit details -
Integrate
FindSymbolsVisitor
intoReferenceTable
We were missing the distinction between properties and enum members, as well as DSC configuration.
Configuration menu - View commit details
-
Copy full SHA for c67f9ee - Browse repository at this point
Copy the full SHA c67f9eeView commit details -
Actually fix sorting in symbols tests
`StartOffset` is always 0, sort by `Range.Start` instead.
Configuration menu - View commit details
-
Copy full SHA for db48839 - Browse repository at this point
Copy the full SHA db48839View commit details -
Make
DocumentSymbolHandler
more readableWhile we're debugging it.
Configuration menu - View commit details
-
Copy full SHA for fd95218 - Browse repository at this point
Copy the full SHA fd95218View commit details -
Fix outline view (filter out
EmptyScriptExtent
)And also prepare `SymbolReference` for eventual support of `DocumentSymbol`.
Configuration menu - View commit details
-
Copy full SHA for 07e566d - Browse repository at this point
Copy the full SHA 07e566dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 85694a3 - Browse repository at this point
Copy the full SHA 85694a3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5776d20 - Browse repository at this point
Copy the full SHA 5776d20View commit details -
Remove notion of
ReferencedFiles
This has been unused and sometimes broken, it doesn't actually power any useful features.
Configuration menu - View commit details
-
Copy full SHA for 63b2143 - Browse repository at this point
Copy the full SHA 63b2143View commit details -
Configuration menu - View commit details
-
Copy full SHA for cd8dd7f - Browse repository at this point
Copy the full SHA cd8dd7fView commit details -
Remove
FindCommandVisitor
,FindSymbolVisitor
and `FindDotSourcedV……isitor` `SymbolsService` is now nullable too.
Configuration menu - View commit details
-
Copy full SHA for 6652213 - Browse repository at this point
Copy the full SHA 6652213View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9a857ea - Browse repository at this point
Copy the full SHA 9a857eaView commit details -
Configuration menu - View commit details
-
Copy full SHA for e5cf5bd - Browse repository at this point
Copy the full SHA e5cf5bdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8c2c9c4 - Browse repository at this point
Copy the full SHA 8c2c9c4View commit details -
Configuration menu - View commit details
-
Copy full SHA for cee7033 - Browse repository at this point
Copy the full SHA cee7033View commit details
Commits on Jan 25, 2023
-
It's so sad we can't use `IAsyncEnumerable`.
Configuration menu - View commit details
-
Copy full SHA for 6b093da - Browse repository at this point
Copy the full SHA 6b093daView commit details -
Configuration menu - View commit details
-
Copy full SHA for 57c563b - Browse repository at this point
Copy the full SHA 57c563bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 74c4382 - Browse repository at this point
Copy the full SHA 74c4382View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8410180 - Browse repository at this point
Copy the full SHA 8410180View commit details
Commits on Jan 26, 2023
-
Configuration menu - View commit details
-
Copy full SHA for c2169ed - Browse repository at this point
Copy the full SHA c2169edView commit details -
Fix jump to definition from outline
By starting at the start of `NameRegion`. Co-authored-by: Frode Flaten <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f1fc140 - Browse repository at this point
Copy the full SHA f1fc140View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7471401 - Browse repository at this point
Copy the full SHA 7471401View commit details -
Configuration menu - View commit details
-
Copy full SHA for 494b0d9 - Browse repository at this point
Copy the full SHA 494b0d9View commit details -
Configuration menu - View commit details
-
Copy full SHA for ec8cf7b - Browse repository at this point
Copy the full SHA ec8cf7bView commit details -
And guard from null exception in definition handler.
Configuration menu - View commit details
-
Copy full SHA for 43baed3 - Browse repository at this point
Copy the full SHA 43baed3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 09fc5d0 - Browse repository at this point
Copy the full SHA 09fc5d0View commit details -
Configuration menu - View commit details
-
Copy full SHA for c8a3bb3 - Browse repository at this point
Copy the full SHA c8a3bb3View commit details
Commits on Jan 27, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 0f1aa19 - Browse repository at this point
Copy the full SHA 0f1aa19View commit details -
Configuration menu - View commit details
-
Copy full SHA for c8abc70 - Browse repository at this point
Copy the full SHA c8abc70View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2592af9 - Browse repository at this point
Copy the full SHA 2592af9View commit details -
Configuration menu - View commit details
-
Copy full SHA for e2d4e25 - Browse repository at this point
Copy the full SHA e2d4e25View commit details -
Configuration menu - View commit details
-
Copy full SHA for bd76db3 - Browse repository at this point
Copy the full SHA bd76db3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 04345dd - Browse repository at this point
Copy the full SHA 04345ddView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2729e83 - Browse repository at this point
Copy the full SHA 2729e83View commit details -
Configuration menu - View commit details
-
Copy full SHA for b634dfa - Browse repository at this point
Copy the full SHA b634dfaView commit details -
Fix
ScriptRegion.ContainsPosition
To actually be an inclusive check of the given point being between the two boundary points.
Configuration menu - View commit details
-
Copy full SHA for e990670 - Browse repository at this point
Copy the full SHA e990670View commit details -
Fix display string for function definitions
Space between name and subsequent parenthesis.
Configuration menu - View commit details
-
Copy full SHA for e407453 - Browse repository at this point
Copy the full SHA e407453View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2f93517 - Browse repository at this point
Copy the full SHA 2f93517View commit details -
Configuration menu - View commit details
-
Copy full SHA for fe29524 - Browse repository at this point
Copy the full SHA fe29524View commit details -
Remove deprecated dot-source reference tests (and data)
Let it be known that Patrick bets $500 that no one notices this. And to be fair, searching the whole workspace now works great.
Configuration menu - View commit details
-
Copy full SHA for f69694c - Browse repository at this point
Copy the full SHA f69694cView commit details -
Fix
FindsDetailsForBuiltInCommand
testAnd delete "find details" for non-commands (as they all get their display strings set on creation now).
Configuration menu - View commit details
-
Copy full SHA for aa6bfc7 - Browse repository at this point
Copy the full SHA aa6bfc7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1829093 - Browse repository at this point
Copy the full SHA 1829093View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6a21c57 - Browse repository at this point
Copy the full SHA 6a21c57View commit details -
Skip
FindsSymbolsInDSCFile
as DSC symbols don't yet workThe visitor exists but it's not called, probably a module-import issue.
Configuration menu - View commit details
-
Copy full SHA for 6d8b0ba - Browse repository at this point
Copy the full SHA 6d8b0baView commit details
Commits on Jan 28, 2023
-
Co-authored-by: Patrick Meinecke <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for fd04c34 - Browse repository at this point
Copy the full SHA fd04c34View commit details
Commits on Jan 31, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 3010065 - Browse repository at this point
Copy the full SHA 3010065View commit details -
Replace
SymbolTypeMatches
logic with prefixed identifiersSo that we rely on the dictionary to sort our symbols into the equivalent types instead of having to perform a filter.
Configuration menu - View commit details
-
Copy full SHA for 0135baa - Browse repository at this point
Copy the full SHA 0135baaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7da6f9d - Browse repository at this point
Copy the full SHA 7da6f9dView commit details -
Handle symbol prefix identifier in
CommandHelpers
I think there's a cleaner way to do this, but this works.
Configuration menu - View commit details
-
Copy full SHA for 4a90f28 - Browse repository at this point
Copy the full SHA 4a90f28View commit details -
More leniently filter workspace symbols
Against the full name and not just the identifier, since it's what's displayed in the search menu. Now you can search methods by their parameters' names.
Configuration menu - View commit details
-
Copy full SHA for 3b08189 - Browse repository at this point
Copy the full SHA 3b08189View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6d2d5a7 - Browse repository at this point
Copy the full SHA 6d2d5a7View commit details
Commits on Feb 1, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 4c1538b - Browse repository at this point
Copy the full SHA 4c1538bView commit details -
Fix bugs in
VisitorUtils
aroundLastIndexOf
Should have been just `IndexOf`, and also use `+` instead of `string.Concat()` for simplicity and speed.
Configuration menu - View commit details
-
Copy full SHA for 9e12670 - Browse repository at this point
Copy the full SHA 9e12670View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0739fc1 - Browse repository at this point
Copy the full SHA 0739fc1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4296553 - Browse repository at this point
Copy the full SHA 4296553View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6208b53 - Browse repository at this point
Copy the full SHA 6208b53View commit details