Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrating class symbol support #16

Closed

Commits on Jan 24, 2023

  1. Bump Microsoft.PowerShell.SDK from 7.3.1 to 7.3.2 (#1986)

    Bumps [Microsoft.PowerShell.SDK](https://github.com/PowerShell/PowerShell) from 7.3.1 to 7.3.2.
    - [Release notes](https://github.com/PowerShell/PowerShell/releases)
    - [Commits](PowerShell/PowerShell@v7.3.1...v7.3.2)
    
    ---
    updated-dependencies:
    - dependency-name: Microsoft.PowerShell.SDK
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    
    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored Jan 24, 2023
    Configuration menu
    Copy the full SHA
    3938982 View commit details
    Browse the repository at this point in the history
  2. add symbols for classes

    fflaten authored and andyleejordan committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    7270bed View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    69a66bb View commit details
    Browse the repository at this point in the history
  4. support hover

    fflaten authored and andyleejordan committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    e3845e8 View commit details
    Browse the repository at this point in the history
  5. add type reference symboltype

    fflaten authored and andyleejordan committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    b1187b9 View commit details
    Browse the repository at this point in the history
  6. support references and definitions

    fflaten authored and andyleejordan committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    7cf22f0 View commit details
    Browse the repository at this point in the history
  7. add codelens for class and enum

    fflaten authored and andyleejordan committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    13adfc3 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    f2be365 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    1d1b5cc View commit details
    Browse the repository at this point in the history
  10. update document symbols test

    fflaten authored and andyleejordan committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    50e8a6c View commit details
    Browse the repository at this point in the history
  11. refactor and cleanup

    fflaten authored and andyleejordan committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    4c3a4ab View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    ad58bcd View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    12b1366 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    884fecb View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    109dbb0 View commit details
    Browse the repository at this point in the history
  16. add symbolsservice tests

    fflaten authored and andyleejordan committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    e776984 View commit details
    Browse the repository at this point in the history
  17. add codelens tests

    fflaten authored and andyleejordan committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    4be7724 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    bca3de0 View commit details
    Browse the repository at this point in the history
  19. fix DSC symbol test

    fflaten authored and andyleejordan committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    da2ad17 View commit details
    Browse the repository at this point in the history
  20. Minor clean-ups

    andyleejordan committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    98fbfbd View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    3eebb45 View commit details
    Browse the repository at this point in the history
  22. Rename overloaded method to ScanForReferencesOfSymbol

    Since `FindReferencesOfSymbol` is already used.
    andyleejordan committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    6469411 View commit details
    Browse the repository at this point in the history
  23. Migrate FindReferencesVisitor to ReferenceTable.ReferenceVisitor

    This required using a `ScriptFile` for the associated test in
    `AstOperationsTests`. The coupling of the visitor to the file seems fine
    since that's the _point_ of this improvement: a cached sets of
    references for each file. We also have to carefully sort our list of
    symbol references for things that expect them in order.
    andyleejordan committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    cf79fd0 View commit details
    Browse the repository at this point in the history
  24. Deduplicate GetSymbolKind, GetDecoratedSymbolName, and `GetRangeF…

    …romScriptRegion`
    
    At least I'm pretty sure these were unnecessary duplicates.
    andyleejordan committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    a335897 View commit details
    Browse the repository at this point in the history
  25. Move reference sorting to unit tests

    Since the client doesn't actually care which order we return the
    references in, we should skip unnecessarily sorting. It appears to apply
    its own sorting to the results regardless of their order, and the
    specification doesn't say it needs to be sorted.
    
    Also adjust two tests to account for the definitions being in the
    reference lists.
    andyleejordan committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    fe3a37e View commit details
    Browse the repository at this point in the history
  26. Configuration menu
    Copy the full SHA
    b17059d View commit details
    Browse the repository at this point in the history
  27. Track declarations on SymbolType so we can use ReferenceTable more

    This lets us (nearly) replace `FindSymbolsInDocument` by using the references
    (symbols) from the `ScriptFile`.
    andyleejordan committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    3a3059f View commit details
    Browse the repository at this point in the history
  28. Integrate FindSymbolsVisitor into ReferenceTable

    We were missing the distinction between properties and enum members,
    as well as DSC configuration.
    andyleejordan committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    c67f9ee View commit details
    Browse the repository at this point in the history
  29. Actually fix sorting in symbols tests

    `StartOffset` is always 0, sort by `Range.Start` instead.
    andyleejordan committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    db48839 View commit details
    Browse the repository at this point in the history
  30. Make DocumentSymbolHandler more readable

    While we're debugging it.
    andyleejordan committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    fd95218 View commit details
    Browse the repository at this point in the history
  31. Fix outline view (filter out EmptyScriptExtent)

    And also prepare `SymbolReference` for eventual support of `DocumentSymbol`.
    andyleejordan committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    07e566d View commit details
    Browse the repository at this point in the history
  32. Fix typo

    andyleejordan committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    85694a3 View commit details
    Browse the repository at this point in the history
  33. Configuration menu
    Copy the full SHA
    5776d20 View commit details
    Browse the repository at this point in the history
  34. Remove notion of ReferencedFiles

    This has been unused and sometimes broken,
    it doesn't actually power any useful features.
    andyleejordan committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    63b2143 View commit details
    Browse the repository at this point in the history
  35. Configuration menu
    Copy the full SHA
    cd8dd7f View commit details
    Browse the repository at this point in the history
  36. Remove FindCommandVisitor, FindSymbolVisitor and `FindDotSourcedV…

    …isitor`
    
    `SymbolsService` is now nullable too.
    andyleejordan committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    6652213 View commit details
    Browse the repository at this point in the history
  37. Configuration menu
    Copy the full SHA
    9a857ea View commit details
    Browse the repository at this point in the history
  38. Configuration menu
    Copy the full SHA
    e5cf5bd View commit details
    Browse the repository at this point in the history
  39. Configuration menu
    Copy the full SHA
    8c2c9c4 View commit details
    Browse the repository at this point in the history
  40. Configuration menu
    Copy the full SHA
    cee7033 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2023

  1. Clean up some IEnumerables

    It's so sad we can't use `IAsyncEnumerable`.
    andyleejordan committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    6b093da View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    57c563b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    74c4382 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    8410180 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2023

  1. Configuration menu
    Copy the full SHA
    c2169ed View commit details
    Browse the repository at this point in the history
  2. Fix jump to definition from outline

    By starting at the start of `NameRegion`.
    
    Co-authored-by: Frode Flaten <[email protected]>
    andyleejordan and fflaten committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    f1fc140 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7471401 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    494b0d9 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    ec8cf7b View commit details
    Browse the repository at this point in the history
  6. Decorate more type names

    And guard from null exception in definition handler.
    andyleejordan committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    43baed3 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    09fc5d0 View commit details
    Browse the repository at this point in the history
  8. Ignore some warnings

    andyleejordan committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    c8a3bb3 View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2023

  1. Configuration menu
    Copy the full SHA
    0f1aa19 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c8abc70 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2592af9 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e2d4e25 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    bd76db3 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    04345dd View commit details
    Browse the repository at this point in the history
  7. Fix FindsPropertyDefinition test

    Name was wrong.
    andyleejordan committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    2729e83 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    b634dfa View commit details
    Browse the repository at this point in the history
  9. Fix ScriptRegion.ContainsPosition

    To actually be an inclusive check of the given point being
    between the two boundary points.
    andyleejordan committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    e990670 View commit details
    Browse the repository at this point in the history
  10. Fix display string for function definitions

    Space between name and subsequent parenthesis.
    andyleejordan committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    e407453 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    2f93517 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    fe29524 View commit details
    Browse the repository at this point in the history
  13. Remove deprecated dot-source reference tests (and data)

    Let it be known that Patrick bets $500 that no one notices this.
    And to be fair, searching the whole workspace now works great.
    andyleejordan committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    f69694c View commit details
    Browse the repository at this point in the history
  14. Fix FindsDetailsForBuiltInCommand test

    And delete "find details" for non-commands (as they all get their
    display strings set on creation now).
    andyleejordan committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    aa6bfc7 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    1829093 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    6a21c57 View commit details
    Browse the repository at this point in the history
  17. Skip FindsSymbolsInDSCFile as DSC symbols don't yet work

    The visitor exists but it's not called, probably a module-import issue.
    andyleejordan committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    6d8b0ba View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2023

  1. Mark some methods internal

    Co-authored-by: Patrick Meinecke <[email protected]>
    andyleejordan and SeeminglyScience authored Jan 28, 2023
    Configuration menu
    Copy the full SHA
    fd04c34 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2023

  1. Configuration menu
    Copy the full SHA
    3010065 View commit details
    Browse the repository at this point in the history
  2. Replace SymbolTypeMatches logic with prefixed identifiers

    So that we rely on the dictionary to sort our symbols into the equivalent
    types instead of having to perform a filter.
    andyleejordan committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    0135baa View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7da6f9d View commit details
    Browse the repository at this point in the history
  4. Handle symbol prefix identifier in CommandHelpers

    I think there's a cleaner way to do this, but this works.
    andyleejordan committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    4a90f28 View commit details
    Browse the repository at this point in the history
  5. More leniently filter workspace symbols

    Against the full name and not just the identifier, since it's
    what's displayed in the search menu.
    
    Now you can search methods by their parameters' names.
    andyleejordan committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    3b08189 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    6d2d5a7 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2023

  1. Configuration menu
    Copy the full SHA
    4c1538b View commit details
    Browse the repository at this point in the history
  2. Fix bugs in VisitorUtils around LastIndexOf

    Should have been just `IndexOf`, and also use `+` instead
    of `string.Concat()` for simplicity and speed.
    andyleejordan committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    9e12670 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0739fc1 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    4296553 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    6208b53 View commit details
    Browse the repository at this point in the history