Revert "fix(deps): update dependency chai to v5 (#263)" #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 00dde0c.
satish-ravi
reviewed
Jan 2, 2024
There was a problem hiding this comment.
Should we just upgrade to node 20 and get chai 5 working? If not, we should at least have chai upgrades blocked, because otherwise immediately after this merges, another chai v5 upgrade PR will be merged by renovate.. Ideally our CI should not allow chai v5 being merged, but I guess we don't have any chai usages in CI.
|
|
satish-ravi
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts Chai upgrade as it only supports greater than Node 18 - Chai 5.x.