-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix footer actions on content grid not aligning to the base of the container #13445
base: 3.x
Are you sure you want to change the base?
Conversation
I'm going to hold off on merging this PR, because I'm not sure if having the actions aligned at the bottom is desired for every use case. |
Would it make sense to have this available as an option on the content grid instead? |
Ideally there'd just be an actions component you could use to create the exact layout you want. Not sure if we're open to an API to configure the current actions position. What do you think, @danharrin? |
You'd need to be able to configure the parent container to align the actions to the bottom, so I don't think thats right |
From your comment it's unclear to me what direction we want to take, @danharrin. |
Personally I can't think of a reason why this PR cannot be merged as-is |
Alright, let's reconsider this then. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please share screenshots of before and after for this change with bulk actions enabled, @rossbearman? Need to make sure this doesn't break any of the combinations (reorder indicator or bulk select checkbox).
When a table is displayed as a grid using
contentGrid()
, if the heights of each row box differs, the footer actions will stick to the bottom of the content, rather than sitting flush with the bottom of the box.A couple of people have encountered and reported this, and this fix has worked in those cases, but this PR has not been thoroughly tested, though it is a small change.
Visual Difference
Before:
After:
Functional changes
flex h-full items-stretch
on content grid rows in place offlex items-center